lkml.org 
[lkml]   [2018]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 08/16] thermal: tsens: Check if the IP is correctly enabled by firmware
    Date
    The SROT registers are initialised by the secure firmware at boot. We
    don't have write access to the registers. Check if the block is enabled
    before continuing.

    Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
    Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    ---
    drivers/thermal/qcom/tsens-common.c | 17 +++++++++++++++++
    1 file changed, 17 insertions(+)

    diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
    index 0b8a793f15f4..3be4be2e0465 100644
    --- a/drivers/thermal/qcom/tsens-common.c
    +++ b/drivers/thermal/qcom/tsens-common.c
    @@ -12,6 +12,10 @@
    #include <linux/regmap.h>
    #include "tsens.h"

    +/* SROT */
    +#define TSENS_EN BIT(0)
    +
    +/* TM */
    #define STATUS_OFFSET 0x30
    #define SN_ADDR_OFFSET 0x4
    #define SN_ST_TEMP_MASK 0x3ff
    @@ -119,7 +123,10 @@ int __init init_common(struct tsens_device *tmdev)
    {
    void __iomem *tm_base, *srot_base;
    struct resource *res;
    + u32 code;
    + int ret;
    struct platform_device *op = of_find_device_by_node(tmdev->dev->of_node);
    + u16 ctrl_offset = tmdev->reg_offsets[SROT_CTRL_OFFSET];

    if (!op)
    return -EINVAL;
    @@ -151,5 +158,15 @@ int __init init_common(struct tsens_device *tmdev)
    if (IS_ERR(tmdev->tm_map))
    return PTR_ERR(tmdev->tm_map);

    + if (tmdev->srot_map) {
    + ret = regmap_read(tmdev->srot_map, ctrl_offset, &code);
    + if (ret)
    + return ret;
    + if (!(code & TSENS_EN)) {
    + dev_err(tmdev->dev, "tsens device is not enabled\n");
    + return -ENODEV;
    + }
    + }
    +
    return 0;
    }
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-09-12 11:54    [W:6.757 / U:0.832 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site