Messages in this thread | | | From | Nick Desaulniers <> | Date | Thu, 2 Aug 2018 10:07:30 -0700 | Subject | Re: [PATCH] inet/connection_sock: prefer _THIS_IP_ to current_text_addr |
| |
On Wed, Aug 1, 2018 at 6:42 PM David Miller <davem@davemloft.net> wrote: > > From: Nick Desaulniers <ndesaulniers@google.com> > Date: Wed, 1 Aug 2018 14:57:59 -0700 > > > - sk, what, when, current_text_addr()); > > + sk, what, when, (void *)_THIS_IP_); > > Is a fugly macro in all caps really better than a function()? > > I'm really surprised that _THIS_IP_ is being chosen over > current_text_addr(), seriously.
See: https://lkml.org/lkml/2018/8/1/1689
I'm happy to rename it on your suggestion, after we've consolidated them.
-- Thanks, ~Nick Desaulniers
| |