Messages in this thread | | | Date | Thu, 02 Aug 2018 15:17:40 -0700 (PDT) | Subject | Re: [PATCH] inet/connection_sock: prefer _THIS_IP_ to current_text_addr | From | David Miller <> |
| |
From: Nick Desaulniers <ndesaulniers@google.com> Date: Thu, 2 Aug 2018 15:10:00 -0700
> On Thu, Aug 2, 2018 at 2:42 PM David Miller <davem@davemloft.net> wrote: >> >> From: Nick Desaulniers <ndesaulniers@google.com> >> Date: Wed, 1 Aug 2018 14:57:59 -0700 >> >> > As part of the effort to reduce the code duplication between _THIS_IP_ >> > and current_text_addr(), let's consolidate callers of >> > current_text_addr() to use _THIS_IP_. >> > >> > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> >> >> I'll ACk this for now: >> >> Acked-by: David S. Miller <davem@davemloft.net> > > Thank you David. Should you take it into the net tree, can you please add: > > Cc: stable@vger.kernel.org # 4.17, 4.14, 4.9, 4.4 > > to the commit message? This will help us as Nathan stated previously > in this thread.
Why in the world is this a stable candidate? It doesn't fix a bug.
My understanding is that you are trying to do a consolidation of code and clean things up so that only one interface is used.
That means it should, at best, go to the net-next tree.
Thank you.
| |