Messages in this thread | | | Subject | Re: [PATCH v10 0/7] i2c: Add FSI-attached I2C master algorithm | From | Eddie James <> | Date | Wed, 27 Jun 2018 08:53:26 -0500 |
| |
On 06/25/2018 09:39 PM, Wolfram Sang wrote: > On Wed, Jun 13, 2018 at 02:36:12PM -0500, Eddie James wrote: >> This series adds an algorithm for an I2C master physically located on an FSI >> slave device. The I2C master has multiple ports, each of which may be connected >> to an I2C slave. Access to the I2C master registers is achieved over FSI bus. >> >> Due to the multi-port nature of the I2C master, the driver instantiates a new >> I2C adapter for each port connected to a slave. The connected ports should be >> defined in the device tree under the I2C master device. > Thanks for this series and your patience. > > While I can see why it also helps reviewing to send it as a series of > multiple patches, I consider applying the driver itself as just one > hunk. I am not decided on this yet. > > I have a few comments, especially about recovery. I replied to the > relevant patches with more detail. > > Also, are you (or someone from your company) willing to maintain the > driver? Then, an addition to MAINTAINERS would be much appreciated.
Thanks for the review Wolfram! I addressed your comments about recovery, please let me know what you think. I will fix the email for the dt patch and make an addition to MAINTAINERS for the next version.
Thanks, Eddie
> > Thanks, > > Wolfram >
| |