Messages in this thread | | | Date | Tue, 26 Jun 2018 11:38:33 +0900 | From | Wolfram Sang <> | Subject | Re: [PATCH v10 7/7] i2c: fsi: Add bus recovery |
| |
On Wed, Jun 13, 2018 at 02:36:19PM -0500, Eddie James wrote: > Bus recovery should reset the engine and force clock the bus 9 times > to recover most situations. > > Signed-off-by: Eddie James <eajames@linux.vnet.ibm.com> > --- > drivers/i2c/busses/i2c-fsi.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-fsi.c b/drivers/i2c/busses/i2c-fsi.c > index d6cab4b..940b198 100644 > --- a/drivers/i2c/busses/i2c-fsi.c > +++ b/drivers/i2c/busses/i2c-fsi.c > @@ -611,6 +611,24 @@ static u32 fsi_i2c_functionality(struct i2c_adapter *adap) > I2C_FUNC_SMBUS_BLOCK_DATA; > } > > +static int fsi_i2c_recover_bus(struct i2c_adapter *adap) > +{ > + int rc; > + struct fsi_i2c_port *port = adap->algo_data; > + struct fsi_i2c_master *master = port->master; > + > + mutex_lock(&master->lock); > + > + rc = fsi_i2c_reset(master, port->port); > + > + mutex_unlock(&master->lock); > + return rc; > +} > + > +static struct i2c_bus_recovery_info fsi_i2c_bus_recovery_info = { > + .recover_bus = fsi_i2c_recover_bus, > +}; > +
This all won't have any effect since you never call i2c_recover_bus which calls back into i2c_bus_recovery_info callbacks.
| |