Messages in this thread | | | Date | Tue, 12 Jun 2018 16:23:01 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH V6] powercap/drivers/idle_injection: Add an idle injection framework |
| |
On Tue, Jun 12, 2018 at 02:00:11PM +0200, Daniel Lezcano wrote: > +static void idle_injection_last_man(struct idle_injection_device *ii_dev) > +{ > + unsigned int run_duration_ms; > + > + run_duration_ms = READ_ONCE(ii_dev->run_duration_ms); > + if (run_duration_ms) { > + hrtimer_start(&ii_dev->timer, ms_to_ktime(run_duration_ms), > + HRTIMER_MODE_REL_PINNED);
What's the point of PINNED here? AFAICT this gets called from a different CPU every time.
> + return; > + } > + > + complete(&ii_dev->stop_complete); > +}
| |