lkml.org 
[lkml]   [2018]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH V6] powercap/drivers/idle_injection: Add an idle injection framework
    From
    Date
    On 12/06/2018 14:30, Peter Zijlstra wrote:
    > On Tue, Jun 12, 2018 at 02:00:11PM +0200, Daniel Lezcano wrote:
    >> +static void __idle_injection_wakeup(struct idle_injection_device *ii_dev)
    >> +{
    >> + struct idle_injection_thread *iit;
    >> + struct cpumask tmp;
    >> + unsigned int cpu;
    >> +
    >> + cpumask_and(&tmp, ii_dev->cpumask, cpu_online_mask);
    >
    > You should not be having a cpumask on the stack. Those things can be
    > ginormous.

    Ok, the kernel code uses of cpumask_t on the stack when dealing with
    cpumask_and. I assume it is also not recommended.

    What would be the best practice ? Allocate a per cpumask at init time as
    a temporary mask to work with ?




    --
    <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

    Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
    <http://twitter.com/#!/linaroorg> Twitter |
    <http://www.linaro.org/linaro-blog/> Blog

    \
     
     \ /
      Last update: 2018-06-12 14:46    [W:4.203 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site