lkml.org 
[lkml]   [2018]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V6] powercap/drivers/idle_injection: Add an idle injection framework
    On Tue, Jun 12, 2018 at 02:00:11PM +0200, Daniel Lezcano wrote:
    > +static void __idle_injection_wakeup(struct idle_injection_device *ii_dev)
    > +{
    > + struct idle_injection_thread *iit;
    > + struct cpumask tmp;
    > + unsigned int cpu;
    > +
    > + cpumask_and(&tmp, ii_dev->cpumask, cpu_online_mask);

    You should not be having a cpumask on the stack. Those things can be
    ginormous.

    \
     
     \ /
      Last update: 2018-06-12 14:31    [W:3.733 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site