| Date | Tue, 1 May 2018 12:31:26 +0200 | From | Daniel Lezcano <> | Subject | Re: [PATCH 14/18] thermal: exynos: move trips setting to exynos_tmu_initialize() |
| |
On Thu, Apr 26, 2018 at 01:51:29PM +0200, Bartlomiej Zolnierkiewicz wrote: > * Add dummy exynos4210_tmu_set_trip_hyst() helper. > > * Add ->tmu_set_trip_temp and ->tmu_set_trip_hyst methods to struct > exynos_tmu_data and set them in exynos_map_dt_data(). > > * Move trips setting to exynos_tmu_initialize(). > > There should be no functional changes caused by this patch. > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > ---
[ ... ]
> +/* failing thresholds are not supported on Exynos4210 */ > +static void exynos4210_tmu_set_trip_hyst(struct exynos_tmu_data *data, > + int trip, u8 temp, u8 hyst) > +{ > +} > +
May be you can get rid of this empty function and check against a NULL pointer in exynos_tmu_initialize ?
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
|