| Date | Tue, 1 May 2018 11:55:40 +0200 | From | Daniel Lezcano <> | Subject | Re: [PATCH 11/18] thermal: exynos: add exynos*_tmu_set_[trip,hyst]() helpers |
| |
On Thu, Apr 26, 2018 at 01:51:26PM +0200, Bartlomiej Zolnierkiewicz wrote: > Add exynos*_tmu_set_[trip,hyst]() helpers and convert > all ->tmu_initialize implementations accordingly. > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > --- > drivers/thermal/samsung/exynos_tmu.c | 282 +++++++++++++++++------------------ > 1 file changed, 140 insertions(+), 142 deletions(-) > > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c > index 82484c5..80265d2 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -305,30 +305,6 @@ static void sanitize_temp_error(struct exynos_tmu_data *data, u32 trim_info) > EXYNOS_TMU_TEMP_MASK; > }
[ ... ]
> +static void exynos4210_tmu_set_trip_temp(struct exynos_tmu_data *data, > + int trip, u8 temp) > +{ > + const struct thermal_trip * const trips = > + of_thermal_get_trip_points(data->tzd); > + u8 ref, th_code;
I would not do this kind of change (unsigned long => u8) with this patch. Just code reorg and another patch to tweak the variable types if needed.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
|