Messages in this thread | | | Subject | Re: hwmon/sch5627: Use common error handling code in sch5627_probe() | From | SF Markus Elfring <> | Date | Tue, 13 Mar 2018 09:25:51 +0100 |
| |
>> Adjust jump targets so that a bit of exception handling can be better >> reused at the end of this function. … > goto-s going to a label calling another goto is completely unreadable.
I got an other software development view.
> I really do not see any reason for the proposed changes,
I suggest to look once more.
> they may remove a small amount of code duplication,
This was my software design goal in this case.
> but at a hugh cost wrt readability.
I proposed a different trade-off here.
Regards, Markus
| |