| Date | Mon, 29 Feb 2016 16:57:13 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH 15/18] uprobes: wait for mmap_sem for write killable |
| |
On 02/29, Michal Hocko wrote: > > --- a/kernel/events/uprobes.c > +++ b/kernel/events/uprobes.c > @@ -1130,7 +1130,9 @@ static int xol_add_vma(struct mm_struct *mm, struct xol_area *area) > struct vm_area_struct *vma; > int ret; > > - down_write(&mm->mmap_sem); > + if (down_write_killable(&mm->mmap_sem)) > + return -EINTR; > +
Yes, but then dup_xol_work() should probably check fatal_signal_pending() to suppress uprobe_warn(), the warning looks like a kernel problem.
Oleg.
|