lkml.org 
[lkml]   [2016]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/18] ipc, shm: make shmem attach/detach wait for mmap_sem killable
On Tue 08-03-16 11:15:50, Davidlohr Bueso wrote:
> On Mon, 29 Feb 2016, Michal Hocko wrote:
>
> >From: Michal Hocko <mhocko@suse.com>
> >
> >shmat and shmdt rely on mmap_sem for write. If the waiting task
> >gets killed by the oom killer it would block oom_reaper from
> >asynchronous address space reclaim and reduce the chances of timely
> >OOM resolving. Wait for the lock in the killable mode and return with
> >EINTR if the task got killed while waiting.
> >
> >Cc: Davidlohr Bueso <dave@stgolabs.net>
> >Cc: Hugh Dickins <hughd@google.com>
> >Signed-off-by: Michal Hocko <mhocko@suse.com>
>
> I have no objection to this perse, just one comment below.
>
> Acked-by: Davidlohr Bueso <dave@stgolabs.net>

Thanks!

[...]
> >- down_write(&current->mm->mmap_sem);
> >+ if (down_write_killable(&current->mm->mmap_sem)) {
> >+ err = -EINVAL;
> >+ goto out_fput;
> >+ }
>
> This should be EINTR, no?

Of course. Thanks for catching that.
--
Michal Hocko
SUSE Labs

\
 
 \ /
  Last update: 2016-03-09 12:01    [W:0.149 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site