lkml.org 
[lkml]   [2016]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 17/18] drm/radeon: make radeon_mn_get wait for mmap_sem killable
    From
    Date
    On 02/29/2016 02:26 PM, Michal Hocko wrote:
    > From: Michal Hocko <mhocko@suse.com>
    >
    > radeon_mn_get which is called during ioct path relies on mmap_sem for
    > write. If the waiting task gets killed by the oom killer it would block
    > oom_reaper from asynchronous address space reclaim and reduce the
    > chances of timely OOM resolving. Wait for the lock in the killable mode
    > and return with EINTR if the task got killed while waiting.
    >
    > Cc: Alex Deucher <alexander.deucher@amd.com>
    > Cc: "Christian König" <christian.koenig@amd.com>
    > Cc: David Airlie <airlied@linux.ie>
    > Signed-off-by: Michal Hocko <mhocko@suse.com>

    Acked-by: Vlastimil Babka <vbabka@suse.cz>

    > ---
    > drivers/gpu/drm/radeon/radeon_mn.c | 4 +++-
    > 1 file changed, 3 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/gpu/drm/radeon/radeon_mn.c b/drivers/gpu/drm/radeon/radeon_mn.c
    > index eef006c48584..896f2cf51e4e 100644
    > --- a/drivers/gpu/drm/radeon/radeon_mn.c
    > +++ b/drivers/gpu/drm/radeon/radeon_mn.c
    > @@ -186,7 +186,9 @@ static struct radeon_mn *radeon_mn_get(struct radeon_device *rdev)
    > struct radeon_mn *rmn;
    > int r;
    >
    > - down_write(&mm->mmap_sem);
    > + if (down_write_killable(&mm->mmap_sem))
    > + return ERR_PTR(-EINTR);
    > +
    > mutex_lock(&rdev->mn_lock);
    >
    > hash_for_each_possible(rdev->mn_hash, rmn, node, (unsigned long)mm)
    >

    \
     
     \ /
      Last update: 2016-03-11 17:01    [W:4.070 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site