Messages in this thread Patch in this message | | | From | Johannes Thumshirn <> | Subject | [PATCH] mei: Destroy mei_idr on module exit. | Date | Wed, 8 Jul 2015 17:12:04 +0200 |
| |
Destroy mei_idr on module exit, reclaiming the allocated memory.
This was detected by the following semantic patch (written by Luis Rodriguez <mcgrof@suse.com>) <SmPL> @ defines_module_init @ declarer name module_init, module_exit; declarer name DEFINE_IDR; identifier init; @@
module_init(init);
@ defines_module_exit @ identifier exit; @@
module_exit(exit);
@ declares_idr depends on defines_module_init && defines_module_exit @ identifier idr; @@
DEFINE_IDR(idr);
@ on_exit_calls_destroy depends on declares_idr && defines_module_exit @ identifier declares_idr.idr, defines_module_exit.exit; @@
exit(void) { ... idr_destroy(&idr); ... }
@ missing_module_idr_destroy depends on declares_idr && defines_module_exit && !on_exit_calls_destroy @ identifier declares_idr.idr, defines_module_exit.exit; @@
exit(void) { ... +idr_destroy(&idr); } </SmPL>
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> --- drivers/misc/mei/main.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c index 8eb0a95..1f04c38 100644 --- a/drivers/misc/mei/main.c +++ b/drivers/misc/mei/main.c @@ -774,6 +774,7 @@ static void __exit mei_exit(void) unregister_chrdev_region(mei_devt, MEI_MAX_DEVS); class_destroy(mei_class); mei_cl_bus_exit(); + idr_destroy(&mei_idr); } module_init(mei_init); -- 2.4.3
| |