lkml.org 
[lkml]   [2015]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] mei: Destroy mei_idr on module exit.
Date
> 
> Destroy mei_idr on module exit, reclaiming the allocated memory.
>
> This was detected by the following semantic patch (written by Luis Rodriguez
> <mcgrof@suse.com>)
> <SmPL>
> @ defines_module_init @
> declarer name module_init, module_exit;
> declarer name DEFINE_IDR;
> identifier init;
> @@
>
> module_init(init);
>
> @ defines_module_exit @
> identifier exit;
> @@
>
> module_exit(exit);
>
> @ declares_idr depends on defines_module_init && defines_module_exit @
> identifier idr;
> @@
>
> DEFINE_IDR(idr);
>
> @ on_exit_calls_destroy depends on declares_idr && defines_module_exit @
> identifier declares_idr.idr, defines_module_exit.exit;
> @@
>
> exit(void)
> {
> ...
> idr_destroy(&idr);
> ...
> }
>
> @ missing_module_idr_destroy depends on declares_idr && defines_module_exit
> && !on_exit_calls_destroy @
> identifier declares_idr.idr, defines_module_exit.exit;
> @@
>
> exit(void)
> {
> ...
> +idr_destroy(&idr);
> }
> </SmPL>
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Ack, this should go probably to stable as well.
Tomas

> ---
> drivers/misc/mei/main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c
> index 8eb0a95..1f04c38 100644
> --- a/drivers/misc/mei/main.c
> +++ b/drivers/misc/mei/main.c
> @@ -774,6 +774,7 @@ static void __exit mei_exit(void)
> unregister_chrdev_region(mei_devt, MEI_MAX_DEVS);
> class_destroy(mei_class);
> mei_cl_bus_exit();
> + idr_destroy(&mei_idr);
> }
>
> module_init(mei_init);
> --
> 2.4.3



\
 
 \ /
  Last update: 2015-07-08 22:41    [W:0.102 / U:3.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site