Messages in this thread | | | Date | Mon, 6 Jul 2015 19:31:50 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 2/2] staging: wilc1000: One function call less in mac_ioctl() after error detection |
| |
On Sat, Jun 27, 2015 at 04:37:24PM +0200, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sat, 27 Jun 2015 16:00:59 +0200
Again, please fix.
> > The kfree() function was called in two cases by the mac_ioctl() function > during error handling even if the passed variable did not contain a pointer > for a valid data item. > > * This implementation detail could be improved by the introduction > of another jump label. > > * Drop an unnecessary initialisation for the variable "buff" then.
That's a different issue, please fix it in a separate patch.
thanks,
greg k-h
| |