lkml.org 
[lkml]   [2016]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 1/3] staging: wilc1000: Delete an unnecessary check before the function call "release_firmware"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sun, 24 Jul 2016 21:00:20 +0200

    The release_firmware() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/staging/wilc1000/linux_wlan.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
    index 3a66255..cdef645 100644
    --- a/drivers/staging/wilc1000/linux_wlan.c
    +++ b/drivers/staging/wilc1000/linux_wlan.c
    @@ -1223,7 +1223,7 @@ void wilc_netdev_cleanup(struct wilc *wilc)
    vif[i] = netdev_priv(wilc->vif[i]->ndev);
    }

    - if (wilc && wilc->firmware) {
    + if (wilc) {
    release_firmware(wilc->firmware);
    wilc->firmware = NULL;
    }
    --
    2.9.2
    \
     
     \ /
      Last update: 2016-07-24 23:01    [W:5.774 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site