Messages in this thread | | | From | Julian Calaby <> | Date | Thu, 28 Jul 2016 22:02:29 +1000 | Subject | Re: [PATCH 2/3] staging: wilc1000: One function call less in mac_ioctl() after error detection |
| |
Hi Marcus,
On Mon, Jul 25, 2016 at 6:22 AM, SF Markus Elfring <elfring@users.sourceforge.net> wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 24 Jul 2016 21:15:23 +0200 > > The kfree() function was called in two cases by the mac_ioctl() function > during error handling even if the passed variable did not contain a pointer > for a valid data item. > > Improve this implementation detail by the introduction of another > jump label. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
This is pointless micro-optimisation: kfree(NULL) is perfectly valid and buff is either malloc'd memory or NULL when it's called.
Thanks,
-- Julian Calaby
Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/
| |