Messages in this thread Patch in this message | | | Date | Fri, 3 Jul 2015 00:48:44 -0700 | From | tip-bot for Taeung Song <> | Subject | [tip:perf/urgent] perf report: Fill in the missing session freeing after an error occurs |
| |
Commit-ID: 07a716fff25b826461baa2a07faa2df8c171f220 Gitweb: http://git.kernel.org/tip/07a716fff25b826461baa2a07faa2df8c171f220 Author: Taeung Song <treeze.taeung@gmail.com> AuthorDate: Tue, 30 Jun 2015 17:15:24 +0900 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Wed, 1 Jul 2015 17:53:49 -0300
perf report: Fill in the missing session freeing after an error occurs
When an error occurs an error value is just returned without freeing the session. So allocating and freeing session have to be matched as a pair even if an error occurs.
Signed-off-by: Taeung Song <treeze.taeung@gmail.com> Acked-by: Jiri Olsa <jolsa@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Link: http://lkml.kernel.org/r/1435652124-22414-6-git-send-email-treeze.taeung@gmail.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/builtin-report.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 348bed4..95a4771 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c @@ -839,8 +839,10 @@ repeat: if (report.header || report.header_only) { perf_session__fprintf_info(session, stdout, report.show_full_info); - if (report.header_only) - return 0; + if (report.header_only) { + ret = 0; + goto error; + } } else if (use_browser == 0) { fputs("# To display the perf.data header info, please use --header/--header-only options.\n#\n", stdout);
| |