Messages in this thread | | | Date | Tue, 30 Jun 2015 13:22:49 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 2/5] perf kmem: Fill in the missing freeing a session after an error occur |
| |
On Tue, Jun 30, 2015 at 05:15:21PM +0900, Taeung Song wrote: > When an error occur a error value is just returned > without freeing the session. So allocating and freeing > session have to be matched as a pair even if an error occur.
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks, jirka
> > Signed-off-by: Taeung Song <treeze.taeung@gmail.com> > --- > tools/perf/builtin-kmem.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c > index 950f296..23b1faa 100644 > --- a/tools/perf/builtin-kmem.c > +++ b/tools/perf/builtin-kmem.c > @@ -1916,7 +1916,7 @@ int cmd_kmem(int argc, const char **argv, const char *prefix __maybe_unused) > if (!perf_evlist__find_tracepoint_by_name(session->evlist, > "kmem:kmalloc")) { > pr_err(errmsg, "slab", "slab"); > - return -1; > + goto out_delete; > } > } > > @@ -1927,7 +1927,7 @@ int cmd_kmem(int argc, const char **argv, const char *prefix __maybe_unused) > "kmem:mm_page_alloc"); > if (evsel == NULL) { > pr_err(errmsg, "page", "page"); > - return -1; > + goto out_delete; > } > > kmem_page_size = pevent_get_page_size(evsel->tp_format->pevent); > -- > 1.9.1 >
| |