Messages in this thread Patch in this message | | | From | Taeung Song <> | Subject | [PATCH 5/5] perf report: Fill in the missing freeing a session after an error occur | Date | Tue, 30 Jun 2015 17:15:24 +0900 |
| |
When an error occur a error value is just returned without freeing the session. So allocating and freeing session have to be matched as a pair even if an error occur.
Signed-off-by: Taeung Song <treeze.taeung@gmail.com> --- tools/perf/builtin-report.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 32626ea..610d056 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c @@ -828,8 +828,10 @@ repeat: if (report.header || report.header_only) { perf_session__fprintf_info(session, stdout, report.show_full_info); - if (report.header_only) - return 0; + if (report.header_only) { + ret = 0; + goto error; + } } else if (use_browser == 0) { fputs("# To display the perf.data header info, please use --header/--header-only options.\n#\n", stdout); -- 1.9.1
| |