Messages in this thread Patch in this message | | | From | Masahiro Yamada <> | Subject | [PATCH 1/2] gpio: altera: use of_mm_gpiochip_remove() to fix memory leak | Date | Wed, 17 Jun 2015 20:59:42 +0900 |
| |
This driver calls of_mm_gpiochip_add() to add a memory mapped gpio chip. So, of_mm_gpiochip_remove() should be used when removing it.
The direct call of gpiochip_remove() misses unmapping the register and freeing the label.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> ---
drivers/gpio/gpio-altera.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-altera.c b/drivers/gpio/gpio-altera.c index 449fb46..c653c83 100644 --- a/drivers/gpio/gpio-altera.c +++ b/drivers/gpio/gpio-altera.c @@ -337,7 +337,7 @@ static int altera_gpio_remove(struct platform_device *pdev) { struct altera_gpio_chip *altera_gc = platform_get_drvdata(pdev); - gpiochip_remove(&altera_gc->mmchip.gc); + of_mm_gpiochip_remove(&altera_gc->mmchip); return -EIO; } -- 1.9.1
| |