Messages in this thread Patch in this message | | | From | Masahiro Yamada <> | Subject | [PATCH 2/2] gpio: altera: fix return value of altera_gpio_remove() | Date | Wed, 17 Jun 2015 20:59:43 +0900 |
| |
The remove callback never succeeds, which seems odd.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> ---
I wonder why nobody has pointed this out before me. I am suspecting -EIO might be intentional. I hope some Altera guys will give me comments.
drivers/gpio/gpio-altera.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-altera.c b/drivers/gpio/gpio-altera.c index c653c83..5861550 100644 --- a/drivers/gpio/gpio-altera.c +++ b/drivers/gpio/gpio-altera.c @@ -339,7 +339,7 @@ static int altera_gpio_remove(struct platform_device *pdev) of_mm_gpiochip_remove(&altera_gc->mmchip); - return -EIO; + return 0; } static const struct of_device_id altera_gpio_of_match[] = { -- 1.9.1
| |