Messages in this thread | | | Subject | Re: [PATCH 4/5] phy: cygnus: pcie: Add Cygnus PCIe PHY support | From | Paul Bolle <> | Date | Thu, 21 May 2015 09:52:55 +0200 |
| |
On Tue, 2015-05-19 at 18:23 -0700, Ray Jui wrote: > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig
> +config PHY_CYGNUS_PCIE > + bool "Broadcom Cygnus PCIe PHY driver" > + depends on ARCH_BCM_CYGNUS > + select GENERIC_PHY > + select PHY_IPROC_MDIO > + default ARCH_BCM_CYGNUS > + help > + Enable this to support the Broadcom Cygnus PCIe PHY. > + > + The host communicates with the PHY through the iProc MDC/MDIO > + interface. > + > + If unsure, say N. > + > +
> --- a/drivers/phy/Makefile > +++ b/drivers/phy/Makefile
> +obj-$(CONFIG_PHY_CYGNUS_PCIE) += phy-cygnus-pcie.o
> --- /dev/null > +++ b/drivers/phy/phy-cygnus-pcie.c
> +#include <linux/module.h>
> +static const struct of_device_id cygnus_pcie_phy_match_table[] = { > + { .compatible = "brcm,cygnus-pcie-phy" }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, cygnus_pcie_phy_match_table); > + > +static struct platform_driver cygnus_pcie_phy_driver = { > + .driver = { > + .name = "cygnus-pcie-phy", > + .of_match_table = cygnus_pcie_phy_match_table, > + }, > + .probe = cygnus_pcie_phy_probe, > +}; > +module_platform_driver(cygnus_pcie_phy_driver); > + > +MODULE_AUTHOR("Ray Jui <rjui@broadcom.com>"); > +MODULE_DESCRIPTION("Broadcom Cygnus PCIe PHY driver"); > +MODULE_LICENSE("GPL v2");
And here I guess you intend this to be buildable as a module. If that's the intention I think PHY_CYGNUS_PCIE needs to be tristate.
Thanks,
Paul Bolle
| |