Messages in this thread | | | Date | Thu, 21 May 2015 16:52:25 -0700 | From | Ray Jui <> | Subject | Re: [PATCH 2/5] phy: iproc-mdio: Initial iProc MDC/MDIO support |
| |
On 5/21/2015 12:41 AM, Paul Bolle wrote: > On Tue, 2015-05-19 at 18:23 -0700, Ray Jui wrote: >> --- a/drivers/phy/Kconfig >> +++ b/drivers/phy/Kconfig >> >> +config PHY_IPROC_MDIO >> + bool "Broadcom iProc MDC/MDIO driver" >> + depends on ARCH_BCM_IPROC >> + default ARCH_BCM_IPROC >> + help >> + Enable this to support the iProc generic MDC/MDIO interface found >> + in various iProc based SoCs. The generic MDC/MDIO interface can be >> + used to communicate with various types of Serdes/PHYs including >> + Ethernet, PCIe, USB, and etc. >> + >> + If unsure, say N. > >> --- a/drivers/phy/Makefile >> +++ b/drivers/phy/Makefile > >> +obj-$(CONFIG_PHY_IPROC_MDIO) += phy-iproc-mdio.o > >> --- /dev/null >> +++ b/drivers/phy/phy-iproc-mdio.c > >> +#include <linux/module.h> > >> +static int __init iproc_mdio_init(void) >> +{ >> + return platform_driver_register(&iproc_mdio_driver); >> +} >> +arch_initcall_sync(iproc_mdio_init); >> + >> +MODULE_AUTHOR("Ray Jui <rjui@broadcom.com>"); >> +MODULE_DESCRIPTION("Broadcom iPROC MDC/MDIO driver"); >> +MODULE_LICENSE("GPL v2"); > > I guess phy-iproc-mdio.o is intended to be built-in only. If that's > correct the above three MODULE_ macros (and, probably, the include of > linux/module.h) can safely be dropped. > > Thanks, > > > Paul Bolle >
I think we had previous discussions on this for the pinctrl patches. People including Linus and me think this is good to be there at least for information purpose.
I do not want to go over the same argument again. I'll leave this to the subsystem maintainer. If the subsystem maintainer wants this out, I can take it out. Otherwise, I'll leave it as it is.
Thanks,
Ray
| |