Messages in this thread Patch in this message | | | From | Julia Lawall <> | Subject | [PATCH 6/16] HSI: cmt_speech: fix error return code | Date | Sun, 5 Apr 2015 14:06:26 +0200 |
| |
Return a negative error code on failure.
A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
--- drivers/hsi/clients/cmt_speech.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/hsi/clients/cmt_speech.c b/drivers/hsi/clients/cmt_speech.c index e9560ef..4983529 100644 --- a/drivers/hsi/clients/cmt_speech.c +++ b/drivers/hsi/clients/cmt_speech.c @@ -1028,6 +1028,7 @@ static int cs_hsi_start(struct cs_hsi_iface **hi, struct hsi_client *cl, } hsi_if->master = ssip_slave_get_master(cl); if (IS_ERR(hsi_if->master)) { + err = PTR_ERR(hsi_if->master); dev_err(&cl->device, "Could not get HSI master client\n"); goto leave4; }
| |