Messages in this thread | | | Date | Sun, 5 Apr 2015 22:57:37 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [PATCH 9/16] HID: logitech-hidpp: fix error return code |
| |
On Sun, 5 Apr 2015, Julia Lawall wrote:
> Return a negative error code on failure. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > identifier ret; expression e1,e2; > @@ > ( > if (\(ret < 0\|ret != 0\)) > { ... return ret; } > | > ret = 0 > ) > ... when != ret = e1 > when != &ret > *if(...) > { > ... when != ret = e2 > when forall > return ret; > } > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied to for-4.1/logitech, thanks.
-- Jiri Kosina SUSE Labs
| |