Messages in this thread | | | Date | Mon, 6 Apr 2015 01:23:09 +0200 | From | Samuel Ortiz <> | Subject | Re: [PATCH 16/16] NFC: pn533: fix error return code |
| |
Hi Julia,
On Sun, Apr 05, 2015 at 02:06:36PM +0200, Julia Lawall wrote: > Return a negative error code on failure. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > identifier ret; expression e1,e2; > @@ > ( > if (\(ret < 0\|ret != 0\)) > { ... return ret; } > | > ret = 0 > ) > ... when != ret = e1 > when != &ret > *if(...) > { > ... when != ret = e2 > when forall > return ret; > } > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > drivers/nfc/pn533.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Applied, thanks.
Cheers, Samuel.
| |