Messages in this thread | | | From | Pranith Kumar <> | Date | Wed, 29 Apr 2015 10:51:40 -0400 | Subject | Re: [PATCH] compiler-intel: fix wrong compiler barrier() macro |
| |
Hi Daniel,
On Wed, Apr 29, 2015 at 10:42 AM, Daniel Borkmann <daniel@iogearbox.net> wrote: > Cleanup commit 23ebdedc67e ("compiler-intel.h: Remove duplicate > definition") removed the double definition of __memory_barrier() > intrinsics. > > However, in doing so, it also removed the preceding #undef barrier, > meaning, the actual barrier() macro from compiler-gcc.h with inline > asm is still in place when __GNUC__ is provided.
When you use the Intel compilers, the barrier() definition will come from compiler.h and not compiler-gcc.h. That is what the commit message says in 73679e508201(your commit message has the wrong hash). I don't understand what problem you are seeing with this, can you please explain?
Thanks!
| |