Messages in this thread | | | Date | Thu, 30 Apr 2015 05:58:48 +0000 | From | mancha security <> | Subject | Re: [PATCH] compiler-intel: fix wrong compiler barrier() macro |
| |
On Wed, Apr 29, 2015 at 12:40:15PM -0400, Pranith Kumar wrote: > On Wed, Apr 29, 2015 at 10:59 AM, mancha security <mancha1@zoho.com> > wrote: > > > > The problem is that ICC defines __GNUC__ so barrier() gets defined > > in compiler-gcc.h. Your commit removed an #undef from > > compiler-intel.h so compiler.h will never define barrier to > > __memory_barrier(). > > > > OK, I see your point. But, ICC has support for GCC inline assembly. So > the change does not seem to be making any difference. We are using our > own asm barrier rather than the inbuilt one provided by ICC. > > -- Pranith
Yes, I misspoke earlier and meant to say ECC rather than ICC.
--mancha [unhandled content-type:application/pgp-signature] | |