Messages in this thread | | | Date | Wed, 29 Apr 2015 18:59:34 +0200 | From | Daniel Borkmann <> | Subject | Re: [PATCH] compiler-intel: fix wrong compiler barrier() macro |
| |
On 04/29/2015 06:40 PM, Pranith Kumar wrote: > On Wed, Apr 29, 2015 at 10:59 AM, mancha security <mancha1@zoho.com> wrote: >> >> The problem is that ICC defines __GNUC__ so barrier() gets defined >> in compiler-gcc.h. Your commit removed an #undef from compiler-intel.h >> so compiler.h will never define barrier to __memory_barrier(). > > OK, I see your point. But, ICC has support for GCC inline assembly. So > the change does not seem to be making any difference. We are using our > own asm barrier rather than the inbuilt one provided by ICC.
It does make a difference: gcc inline assembly is not supported by /ecc/, see that it's wrapped within the ifdef __ECC part. I believe, that should be for ia64 which we have under arch/, no?
| |