Messages in this thread | | | Subject | Re: [PATCH 1/4] mailbox: add support for System Control and Power Interface(SCPI) protocol | From | Paul Bolle <> | Date | Tue, 28 Apr 2015 09:36:04 +0200 |
| |
Just one nit: a license mismatch.
On Mon, 2015-04-27 at 12:40 +0100, Sudeep Holla wrote: > --- /dev/null > +++ b/drivers/mailbox/scpi_protocol.c
> + * This program is free software; you can redistribute it and/or modify it > + * under the terms and conditions of the GNU General Public License, > + * version 2, as published by the Free Software Foundation. > + * > + * This program is distributed in the hope it will be useful, but WITHOUT > + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for > + * more details. > + * > + * You should have received a copy of the GNU General Public License along > + * with this program. If not, see <http://www.gnu.org/licenses/>.
This states the license is GPL v2.
> +MODULE_LICENSE("GPL");
And, according to include/linux/module.h, this states the license is GPL v2 or later. So I think either the comment at the top of this file or the license ident used in the MODULE_LICENSE() macro should be changed.
Likewise for 2/4 and 4/4.
Thanks,
Paul Bolle
| |