Messages in this thread | | | Date | Tue, 26 May 2015 14:14:23 +0100 | From | Sudeep Holla <> | Subject | Re: [PATCH 2/4] clk: add support for clocks provided by SCP(System Control Processor) |
| |
Hi Stephen,
On 21/05/15 00:43, Stephen Boyd wrote: > On 04/27, Sudeep Holla wrote: >> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig >> index 9897f353bf1a..906bf7dd72a2 100644 >> --- a/drivers/clk/Kconfig >> +++ b/drivers/clk/Kconfig >> @@ -59,6 +59,16 @@ config COMMON_CLK_RK808 >> clocked at 32KHz each. Clkout1 is always on, Clkout2 can off >> by control register. >> >> +config COMMON_CLK_SCPI >> + tristate "Clock driver controlled via SCPI interface" >> + depends on ARM_SCPI_PROTOCOL > > || COMPILE_TEST ? >
[...]
> >> + return -ENOMEM; >> + } >> + >> + for (idx = 0; idx < count; idx++) { >> + struct scpi_clk *sclk; > [...] >> +static int scpi_clk_remove(struct platform_device *pdev) >> +{ >> + of_clk_del_provider(pdev->dev.of_node); >> + platform_set_drvdata(pdev, NULL); > > We don't need to set platform_drvdata to NULL here. >
Thanks for the review. I have posted v2 of this series and some of the comments are not applicable(already done or code removed). I have fixed all the remaining comments locally for v3.
Regards, Sudeep
| |