lkml.org 
[lkml]   [2015]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/8] regulator: introduce regulator_get_voltage_floor
On Tue, Oct 13, 2015 at 12:45:28PM +0200, Sascha Hauer wrote:

> + num_voltages = regulator_count_voltages(regulator);
> + if (num_voltages < 0)
> + return num_voltages;

> + for (i = 0; i < num_voltages; i++) {
> + now = _regulator_list_voltage(regulator, i, 0);
> + if (now < 0)
> + continue;
> + if (now < best && now >= min_uV)
> + best = now;
> + }

Why is this not a factoring out of existing code (indeed it is itself a
reimplementation of regulator_map_voltage_iterate())? This will also be
a substantial performance loss in cases where we have a known mapping
function - we should use a map_voltage() operation if one exists like we
do in _do_set_voltage(). That has logic to handle missing mapping
functions as a transition measure, now I look at it we should probably
remove that code and just require that the mapping function is set if
appropriate.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-10-16 19:21    [W:0.139 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site