Messages in this thread |  | | Date | Fri, 5 Sep 2014 12:59:49 +0200 | From | Oleg Nesterov <> | Subject | Re: [RFC v2 3/6] kthread: warn on kill signal if not OOM |
| |
On 09/04, Luis R. Rodriguez wrote: > > From: "Luis R. Rodriguez" <mcgrof@suse.com> > > The new umh kill option has allowed kthreads to receive > kill signals but they are generally accepting all sources > of kill signals
And I think this is right,
> while the original motivation was to enable > through the OOM from sending the kill.
even if the main concern was OOM.
> Users can provide a log output and it should be clear on > the trace what probe / driver got the kill signal.
Well, if you need a WARN output, perhaps you could just add WARN_ON(fatal_signal_pending()) at the end of load_module() ?
Not only kthread_create() can fail if systemd sends SIGKILL.
> Although Oleg had rejected a > similar change a while ago
And honestly, I still dislike this change.
Oleg.
|  |