lkml.org 
[lkml]   [2014]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC v2 3/6] kthread: warn on kill signal if not OOM
On Thu, Sep 04, 2014 at 11:37:24PM -0700, Luis R. Rodriguez wrote:
...
> + /*
> + * I got SIGKILL, but wait for 60 more seconds for completion
> + * unless chosen by the OOM killer. This delay is there as a
> + * workaround for boot failure caused by SIGKILL upon device
> + * driver initialization timeout.
> + *
> + * N.B. this will actually let the thread complete regularly,
> + * wait_for_completion() will be used eventually, the 60 second
> + * try here is just to check for the OOM over that time.
> + */
> + WARN_ONCE(!test_thread_flag(TIF_MEMDIE),
> + "Got SIGKILL but not from OOM, if this issue is on probe use .driver.async_probe\n");
> + for (i = 0; i < 60 && !test_thread_flag(TIF_MEMDIE); i++)
> + if (wait_for_completion_timeout(&done, HZ))
> + goto wait_done;
> +

Ugh... Jesus, this is way too hacky, so now we fail on 90s timeout
instead of 30? Why do we even need this with the proposed async
probing changes?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2014-09-05 10:01    [W:0.302 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site