Messages in this thread |  | | Date | Fri, 5 Sep 2014 16:15:35 +0900 | From | Tejun Heo <> | Subject | Re: [RFC v2 6/6] pata_marvell: use async probe |
| |
On Thu, Sep 04, 2014 at 11:37:27PM -0700, Luis R. Rodriguez wrote: > diff --git a/drivers/ata/pata_marvell.c b/drivers/ata/pata_marvell.c > index ae9feb1..6a543b9 100644 > --- a/drivers/ata/pata_marvell.c > +++ b/drivers/ata/pata_marvell.c > @@ -175,6 +175,7 @@ static struct pci_driver marvell_pci_driver = { > .suspend = ata_pci_device_suspend, > .resume = ata_pci_device_resume, > #endif > + .driver.async_probe = true,
You can't do this. There's nothing special about pata_marvell. Sure there was a bug report which made long probe durations more common on this driver on certain configurations but those long durations can happen on *any* libata driver and singling out pata_marvell for async probing is adding a different probing behavior basically arbitrarily. I really can't see how this marking random drivers with async probing would work, so one driver does synchronous probing while the equivalent next one doesn't? That's crazy.
Thanks.
-- tejun
|  |