lkml.org 
[lkml]   [2014]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx
> >+	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>
> Error checking on *res*...?
>
> We should *return* on platform_get_resource() failure..
>
> >+ base = devm_ioremap_resource(&pdev->dev, res);

Nope. devm_ioremap_resource does that.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-09-29 12:21    [W:0.076 / U:3.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site