Messages in this thread | | | Date | Fri, 3 Oct 2014 13:04:54 +0200 | Subject | Re: [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx | From | Anders Berg <> |
| |
On Fri, Oct 3, 2014 at 12:36 PM, Wolfram Sang <wsa@the-dreams.de> wrote: >> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig >> index 2ac87fa..8983474 100644 >> --- a/drivers/i2c/busses/Kconfig >> +++ b/drivers/i2c/busses/Kconfig >> @@ -77,6 +77,17 @@ config I2C_AMD8111 >> This driver can also be built as a module. If so, the module >> will be called i2c-amd8111. >> >> +config I2C_AXXIA >> + tristate "Axxia I2C controller" >> + depends on ARCH_AXXIA || COMPILE_TEST >> + default ARCH_AXXIA >> + help >> + Say yes if you want to support the I2C bus on Axxia platforms. >> + >> + Please note that this controller is limited to transfers of maximum >> + 255 bytes in length. Any attempt to to a larger transfer will return >> + an error. >> + >> config I2C_I801 >> tristate "Intel 82801 (ICH/PCH)" >> depends on PCI >> diff --git a/drivers/i2c/busses/Makefile b/drivers/i2c/busses/Makefile >> index 49bf07e..5899edb 100644 >> --- a/drivers/i2c/busses/Makefile >> +++ b/drivers/i2c/busses/Makefile >> @@ -12,6 +12,7 @@ obj-$(CONFIG_I2C_ALI15X3) += i2c-ali15x3.o >> obj-$(CONFIG_I2C_AMD756) += i2c-amd756.o >> obj-$(CONFIG_I2C_AMD756_S4882) += i2c-amd756-s4882.o >> obj-$(CONFIG_I2C_AMD8111) += i2c-amd8111.o >> +obj-$(CONFIG_I2C_AXXIA) += i2c-axxia.o >> obj-$(CONFIG_I2C_I801) += i2c-i801.o >> obj-$(CONFIG_I2C_ISCH) += i2c-isch.o >> obj-$(CONFIG_I2C_ISMT) += i2c-ismt.o > > Please put it to the embedded section. >
OK.
> ... > >> + idev->adapter.class = I2C_CLASS_HWMON; > > Being a DT driver, you most probably don't need this. >
Right, thanks. I'll fix up these and submit a v3.
/Anders
| |