Messages in this thread | | | Date | Mon, 29 Sep 2014 15:43:16 +0530 | From | Varka Bhadram <> | Subject | Re: [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx |
| |
On 09/29/2014 03:43 PM, Wolfram Sang wrote: >>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> Error checking on *res*...? >> >> We should *return* on platform_get_resource() failure.. >> >>> + base = devm_ioremap_resource(&pdev->dev, res); > Nope. devm_ioremap_resource does that. > Yes it will [1]. Thanks for the clarification.
[1]:http://lxr.free-electrons.com/source/lib/devres.c#L117
-- Regards, Varka Bhadram.
| |