lkml.org 
[lkml]   [2014]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCHSET 0/5] perf hists browser: Cleanup callchain routines
Date
Hello,

This patch fixes and cleans up TUI callchain routines. I tried to
consolidate similar functions but not to break the current output with
this change. Hope that it makes code more readable and maintainable.

It should not change any behavior and outputs. I verified it with
expanding by 'E' key + dumping by 'P' key on TUI and then running
"diff -u" results before and after the patchset.

Actually I have more changes that would change (or improve) some
behavior and output. I'll post them after this patchset is merged.

You can get this from 'perf/callchain-fix-v1' branch on my tree:

git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Any comments are welcome, thanks
Namhyung


Namhyung Kim (5):
perf hists browser: Fix children overhead dump
perf hists browser: Factor out hist_browser__show_callchain_entry()
perf hists browser: Get rid of unused 'remaining' variable
perf hists browser: Cleanup callchain print functions
perf hists browser: Consolidate callchain print functions in TUI

tools/perf/ui/browsers/hists.c | 349 ++++++++++++++---------------------------
tools/perf/ui/hist.c | 2 +-
2 files changed, 117 insertions(+), 234 deletions(-)

--
2.0.0



\
 
 \ /
  Last update: 2014-08-20 10:21    [W:0.067 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site