lkml.org 
[lkml]   [2014]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 3/5] perf hists browser: Get rid of unused 'remaining' variable
Date
It seems that the 'remaining' variable is not used by any real code.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/ui/browsers/hists.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index 2abb0c5cbbaa..d42d8a8f3810 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -511,14 +511,13 @@ static int hist_browser__show_callchain_node_rb_tree(struct hist_browser *browse
{
struct rb_node *node;
int first_row = row, offset = level * LEVEL_OFFSET_STEP;
- u64 new_total, remaining;
+ u64 new_total;

if (callchain_param.mode == CHAIN_GRAPH_REL)
new_total = chain_node->children_hit;
else
new_total = total;

- remaining = new_total;
node = rb_first(&chain_node->rb_root);
while (node) {
struct callchain_node *child = rb_entry(node, struct callchain_node, rb_node);
@@ -529,8 +528,6 @@ static int hist_browser__show_callchain_node_rb_tree(struct hist_browser *browse
int first = true;
int extra_offset = 0;

- remaining -= cumul;
-
list_for_each_entry(chain, &child->val, list) {
char bf[1024], *alloc_str;
const char *str;
@@ -1086,7 +1083,7 @@ static int hist_browser__fprintf_callchain_node_rb_tree(struct hist_browser *bro
{
struct rb_node *node;
int offset = level * LEVEL_OFFSET_STEP;
- u64 new_total, remaining;
+ u64 new_total;
int printed = 0;

if (callchain_param.mode == CHAIN_GRAPH_REL)
@@ -1094,7 +1091,6 @@ static int hist_browser__fprintf_callchain_node_rb_tree(struct hist_browser *bro
else
new_total = total;

- remaining = new_total;
node = rb_first(&chain_node->rb_root);
while (node) {
struct callchain_node *child = rb_entry(node, struct callchain_node, rb_node);
@@ -1105,8 +1101,6 @@ static int hist_browser__fprintf_callchain_node_rb_tree(struct hist_browser *bro
int first = true;
int extra_offset = 0;

- remaining -= cumul;
-
list_for_each_entry(chain, &child->val, list) {
char bf[1024], *alloc_str;
const char *str;
--
2.0.0


\
 
 \ /
  Last update: 2014-08-20 10:21    [W:0.122 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site