Messages in this thread | | | From | KY Srinivasan <> | Subject | RE: [PATCH 2/8] Drivers: scsi: storvsc: Filter commands based on the storage protocol version | Date | Wed, 9 Jul 2014 20:02:41 +0000 |
| |
> -----Original Message----- > From: Christoph Hellwig [mailto:hch@infradead.org] > Sent: Wednesday, July 9, 2014 1:41 AM > To: KY Srinivasan > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; > ohering@suse.com; jbottomley@parallels.com; jasowang@redhat.com; > apw@canonical.com; linux-scsi@vger.kernel.org; stable@vger.kernel.org > Subject: Re: [PATCH 2/8] Drivers: scsi: storvsc: Filter commands based on the > storage protocol version > > On Tue, Jul 08, 2014 at 05:46:46PM -0700, K. Y. Srinivasan wrote: > > Going forward it is possible that some of the commands that are not > > currently implemented will be implemented on future Windows hosts. > > Make command filtering depend on the host version. > > > + if (vmstor_current_major <= VMSTOR_WIN8_MAJOR) { > > + /* > > + * On legacy hosts filter unimplemented commands. > > + */ > > + if (!storvsc_scsi_cmd_ok(scmnd)) { > > + scmnd->scsi_done(scmnd); > > + return 0; > > + } > > So post-Win8 versions don't need command filering as they can properly > reject commands they don't understand? If that's the case please state it in > the patch description.
I will add the comments you have suggested.
K. Y
| |