| Date | Wed, 9 Jul 2014 01:39:54 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/8] Drivers: scsi: storvsc: Change the limits to reflect the values on the host |
| |
On Tue, Jul 08, 2014 at 05:46:45PM -0700, K. Y. Srinivasan wrote: > + * In Hyper-V, each port/path/target maps to 1 scsi host adapter.
Does it still? The STORVSC_FC_MAX_TARGETS define suggests otherwise.
> - .cmd_per_lun = 1, > + .cmd_per_lun = 255,
This looks like an unrelated change.
> + /* max # of devices per target */ > + host->max_lun = STORVSC_FC_MAX_LUNS_PER_TARGET; > + /* max # of targets per channel */ > + host->max_id = STORVSC_FC_MAX_TARGETS; > + /* max # of channels */ > + host->max_channel = STORVSC_FC_MAX_CHANNELS - 1;
I don't think these comments add any value..
Also any reason you use off by one defines for max_channel, but not the others?
|