Messages in this thread | | | From | KY Srinivasan <> | Subject | RE: [PATCH 1/8] Drivers: scsi: storvsc: Change the limits to reflect the values on the host | Date | Wed, 9 Jul 2014 20:07:25 +0000 |
| |
> -----Original Message----- > From: Christoph Hellwig [mailto:hch@infradead.org] > Sent: Wednesday, July 9, 2014 1:40 AM > To: KY Srinivasan > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; > ohering@suse.com; jbottomley@parallels.com; jasowang@redhat.com; > apw@canonical.com; linux-scsi@vger.kernel.org; stable@vger.kernel.org > Subject: Re: [PATCH 1/8] Drivers: scsi: storvsc: Change the limits to reflect the > values on the host > > On Tue, Jul 08, 2014 at 05:46:45PM -0700, K. Y. Srinivasan wrote: > > + * In Hyper-V, each port/path/target maps to 1 scsi host adapter. > > Does it still? The STORVSC_FC_MAX_TARGETS define suggests otherwise.
I will fix the comments and get rid of unnecessary comments.
> > > - .cmd_per_lun = 1, > > + .cmd_per_lun = 255, > > This looks like an unrelated change.
I will have a separate patch for this. > > > + /* max # of devices per target */ > > + host->max_lun = STORVSC_FC_MAX_LUNS_PER_TARGET; > > + /* max # of targets per channel */ > > + host->max_id = STORVSC_FC_MAX_TARGETS; > > + /* max # of channels */ > > + host->max_channel = STORVSC_FC_MAX_CHANNELS - 1; > > I don't think these comments add any value..
I will get rid of the comments.
> > Also any reason you use off by one defines for max_channel, but not the > others?
No particular reason; I will clean this up.
Thanks Christoph for the detailed comments. I will re-spin these after I address your comments.
Regards,
K. Y
| |