Messages in this thread | | | Date | Sat, 5 Jul 2014 19:20:48 +0100 (BST) | From | "Maciej W. Rozycki" <> | Subject | Re: [PATCH v2] declance: Fix 64-bit compilation warnings |
| |
On Sat, 5 Jul 2014, Joe Perches wrote:
> > > I think it's a mistake and I agree. > > > > > > I submitted a patch to remove the prefix from %pad. > > > > > > https://lkml.org/lkml/2014/3/21/333 > > > > Great! Your proposal looks good to me in principle, however you need to > > factor in SPECIAL having been set by `#' somehow as `number' will respect > > it. I suggest using the same field width calculation that `pointer' uses > > for `default_width' (sans the type used with `sizeof' of course, that is). > > I don't think %#p is valid so it > shouldn't have been set by #.
Huh? As recently as last Wednesday you pointed me at the specific commit from Grant that made it valid (GCC format complaints aside).
Maciej
| |