lkml.org 
[lkml]   [2014]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] declance: Fix 64-bit compilation warnings
On Sat, 5 Jul 2014, Joe Perches wrote:

> > One question though, does either of you or anybody else know why we're
> > inconsistent about this 0x prefixing of virtual addresses vs physical
> > addresses? Specifically %p vs e.g. %pad.
>
> I think it's a mistake and I agree.
>
> I submitted a patch to remove the prefix from %pad.
>
> https://lkml.org/lkml/2014/3/21/333

Great! Your proposal looks good to me in principle, however you need to
factor in SPECIAL having been set by `#' somehow as `number' will respect
it. I suggest using the same field width calculation that `pointer' uses
for `default_width' (sans the type used with `sizeof' of course, that is).

Maciej


\
 
 \ /
  Last update: 2014-07-05 20:21    [W:0.065 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site