Messages in this thread | | | Subject | Re: [PATCH v2] declance: Fix 64-bit compilation warnings | From | Joe Perches <> | Date | Sat, 05 Jul 2014 11:08:59 -0700 |
| |
On Sat, 2014-07-05 at 18:39 +0100, Maciej W. Rozycki wrote: > On Sat, 5 Jul 2014, Joe Perches wrote: > > > > One question though, does either of you or anybody else know why we're > > > inconsistent about this 0x prefixing of virtual addresses vs physical > > > addresses? Specifically %p vs e.g. %pad. > > > > I think it's a mistake and I agree. > > > > I submitted a patch to remove the prefix from %pad. > > > > https://lkml.org/lkml/2014/3/21/333 > > Great! Your proposal looks good to me in principle, however you need to > factor in SPECIAL having been set by `#' somehow as `number' will respect > it. I suggest using the same field width calculation that `pointer' uses > for `default_width' (sans the type used with `sizeof' of course, that is).
I don't think %#p is valid so it shouldn't have been set by #.
| |