Messages in this thread | | | From | "Luck, Tony" <> | Subject | RE: [PATCH v2] x86/mce: Improve mcheck_init_device() error handling | Date | Mon, 5 May 2014 23:29:14 +0000 |
| |
+err_device_create: + /* + * mce_device_remove behave properly if mce_device_create was not + * called on that device. + */ + for_each_possible_cpu(i) + mce_device_remove(i);
grammar comment "s/behave/behaves/"
Though perhaps this is better:
/* * We didn't keep track of which devices were created above, but * even if we had, the set of online cpus might have changed. * Play safe and remove for every possible cpu since mce_device_remove() * will do the right thing. */
-Tony
| |